Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make plugin options optional #145

Merged
merged 2 commits into from Aug 19, 2021
Merged

feat: make plugin options optional #145

merged 2 commits into from Aug 19, 2021

Conversation

guybedford
Copy link
Contributor

Resolves #144.

styfle
styfle previously approved these changes Aug 19, 2021
View reviewed changes
@styfle
Copy link
Member

styfle commented Aug 19, 2021 •
edited

Looks like CI is failing:

FAIL test/project.test.js
  ● should correctly run webpack build project-chunking

    ENOENT: no such file or directory, open '/home/runner/work/webpack-asset-relocator-loader/webpack-asset-relocator-loader/test/project-chunking/dist/modules/chunks/541.js'

@styfle styfle merged commit 4cdf816 into main Aug 19, 2021
@styfle styfle deleted the optional-options branch August 19, 2021 20:09
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@Timer Timer Timer approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors out when options isn't specified
3 participants
@guybedford @styfle @Timer