feat: make plugin options optional (#145)

* feat: make plugin options optional * update test
vercel · Aug 19, 2021 · 4cdf816 · 4cdf816
1 parent 505f983
commit 4cdf816
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/src/asset-relocator.js b/src/asset-relocator.js
@@ -350,7 +350,7 @@ module.exports = async function (content, map) {
   const dir = path.dirname(id);
 
   // injection to set __webpack_require__.ab
-  const options = getOptions(this);
+  const options = getOptions(this) || {};
 
   injectPathHook(this._compilation, options.outputAssetBase);
 

diff --git a/test/project-chunking/expected.js b/test/project-chunking/expected.js
@@ -6,4 +6,4 @@ expect(output.length).toBe(16);
 // check relative asset references worked out
 expect(fs.readFileSync(__dirname + "/dist/modules/main.js").toString()).toContain(`ab+"asset`);
 expect(fs.readFileSync(__dirname + "/dist/modules/chunk.js").toString()).toContain(`ab+"asset`);
-expect(fs.readFileSync(__dirname + "/dist/modules/chunks/541.js").toString()).toContain(`ab+"asset`);
+expect(fs.readFileSync(__dirname + "/dist/modules/chunks/758.js").toString()).toContain(`ab+"asset`);
diff --git a/test/project-chunking/webpack.config.js b/test/project-chunking/webpack.config.js
@@ -16,10 +16,7 @@ module.exports = {
       test: /\.m?js$/,
       parser: { amd: false },
       use: {
-        loader: __dirname + '/../../src/asset-relocator.js',
-        options: {
-          wrapperCompatibility: true
-        }
+        loader: __dirname + '/../../src/asset-relocator.js'
       }
     }]
   }