[next] Fix edge runtime for route groups #9764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
semver: patch
ijjk
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
shuding
previously approved these changes
Apr 6, 2023
huozhi
previously approved these changes
Apr 6, 2023
… into ijjk/fix-edge-route-groups
|
Hi @ijjk - how can I use this in production? We've encountered this issue and with Next 13.2.x w/ app dir it won't work for me. Do I need to set the I would love to know what we can do to opt in b/c we're seeing slowness and I'd like to move our app dir project 100% to edge functions. |
|
@djfarrelly this should now be available in production, please re-deploy your project and give it a try! |
|
Thanks @ijjk! My latest deploy worked correctly now - I appreciate the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we use the correct short name when generating edge functions with route groups from app directory.
Example deployment with fix can be seen here https://next-debug-edge-runtime-1ar7agbjh-vtest314-ijjk-testing.vercel.app/group-no-layout
Fixes: vercel/next.js#43458