Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Add cron job to update gatsby fixtures #9510

Merged
merged 5 commits into from
Feb 28, 2023
Merged

[tests] Add cron job to update gatsby fixtures #9510

merged 5 commits into from
Feb 28, 2023

Conversation

Ethan-Arrowood
Copy link
Contributor

PR to add a cron job and script that automatically updates gatsby fixture versions.

@Ethan-Arrowood Ethan-Arrowood added area: tests semver: none PR is not relevant to publishing labels Feb 22, 2023
@Ethan-Arrowood
Copy link
Contributor Author

Another option to doing the whole npm view check is to use: npm i gatsby@<tag> --save-exact --package-lock-only which will update the gatsby package version to the right semver value (i.e. 4.24.4) and update the package lock file all in one...without actually installing all the dependencies I think

@Ethan-Arrowood Ethan-Arrowood mentioned this pull request Feb 25, 2023
Closed
@Ethan-Arrowood Ethan-Arrowood marked this pull request as ready for review February 28, 2023 18:48
@Ethan-Arrowood Ethan-Arrowood added the pr: automerge Automatically merge the PR when checks pass label Feb 28, 2023
@TooTallNate TooTallNate merged commit 3df8c05 into main Feb 28, 2023
@TooTallNate TooTallNate deleted the fix-gatsby-tests branch February 28, 2023 19:32
EndangeredMassa
EndangeredMassa reviewed Feb 28, 2023
View reviewed changes
utils/update-gatsby-fixtures.js Outdated Show resolved Hide resolved
utils/update-gatsby-fixtures.js
exec('git', ['config', '--global', 'user.name', 'vercel-release-bot']);
try {
// Branch may exist if there's already an existing PR
exec('git', ['checkout', branch]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (non-blocking): should we also merge main in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume itd happen automatically cause of automerge or our manual input. if it becomes an issue Ill modify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndangeredMassa EndangeredMassa EndangeredMassa left review comments

@TooTallNate TooTallNate TooTallNate approved these changes

@styfle styfle Awaiting requested review from styfle

@cb1kenobi cb1kenobi Awaiting requested review from cb1kenobi

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
area: tests pr: automerge Automatically merge the PR when checks pass semver: none PR is not relevant to publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ethan-Arrowood @EndangeredMassa @TooTallNate