-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Replace update-notifier
dependency with built in (part 2)
#9092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcel/vercel into replace-update-notifier-with-built-in
…it into getLatestVersion()
cb1kenobi
added
area: cli
semver: patch
PR contains bug fixes
pr: automerge
Automatically merge the PR when checks pass
labels
Dec 17, 2022
cb1kenobi
requested review from
timneutkens,
ijjk,
styfle,
Timer,
leerob,
a team,
TooTallNate,
EndangeredMassa,
Ethan-Arrowood,
agadzik,
chloetedder,
mglagola and
anatrajkovska
as code owners
December 17, 2022 23:46
kodiakhq
bot
removed
the
pr: automerge
Automatically merge the PR when checks pass
label
Dec 17, 2022
This PR currently has a merge conflict. Please resolve this and then re-add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
update-notifier
dependency with a custom implementation.This PR is a continuation of #8090 where the
get-latest-worker.js
file no longer relies on external dependencies, only built-in Node.js APIs.