[next][routing-utils] Add missing matcher support #8874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: routing-utils
semver: patch
11 tasks
ijjk
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
TooTallNate
approved these changes
Nov 9, 2022
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Nov 9, 2022
This adds support for a `missing` field which is complimentary to `has` to only match when `query`, `header`, or `cookie` values are not present. The `missing` field can be applied for middleware matchers as well to prevent running middleware when these fields are present. x-ref: vercel/vercel#8874 x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1667935428788529?thread_ts=1667850697.542269&cid=C03S8ED1DKM) x-ref: #25653 x-ref: #34046 x-ref: #28185 x-ref: #25930 x-ref: #24608 x-ref: #27431 ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm build && pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This adds handling to ensure we pass through the
missingroute field correctly for custom routes and middleware matchers. Tests are also added in the complimentary Next.js PR for this, example deployment can be seen here https://vtest314-e2e-tests-jj4-vtest314-next-e2e-tests.vercel.app/x-ref: slack thread
x-ref: vercel/next.js#42660
馃搵 Checklist
Tests
yarn test-unitCode Review