Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Adding client directive #8582

Closed
wants to merge 1 commit into from
Closed

[tests] Adding client directive #8582

wants to merge 1 commit into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 19, 2022 •
edited

Related Issues

Fixes failing build for nextjs fixture app-dir
related change: vercel/next.js#40603

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@huozhi huozhi changed the title Adding client directive [tests] Adding client directive Sep 19, 2022
@huozhi
Copy link
Member Author

huozhi commented Sep 19, 2022

Close in favor of #8584

@huozhi huozhi closed this Sep 19, 2022
@huozhi huozhi deleted the adding-client-directive branch September 19, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate will be requested when the pull request is marked ready for review TooTallNate is a code owner

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa will be requested when the pull request is marked ready for review EndangeredMassa is a code owner

@trek trek Awaiting requested review from trek trek will be requested when the pull request is marked ready for review trek is a code owner

@onsclom onsclom Awaiting requested review from onsclom onsclom will be requested when the pull request is marked ready for review onsclom is a code owner

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55 jeffsee55 will be requested when the pull request is marked ready for review jeffsee55 is a code owner

@erikareads erikareads Awaiting requested review from erikareads erikareads will be requested when the pull request is marked ready for review erikareads is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens will be requested when the pull request is marked ready for review timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk will be requested when the pull request is marked ready for review ijjk is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner will be requested when the pull request is marked ready for review ztanner is a code owner

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood Ethan-Arrowood will be requested when the pull request is marked ready for review Ethan-Arrowood is a code owner

@styfle styfle Awaiting requested review from styfle styfle will be requested when the pull request is marked ready for review styfle is a code owner

Assignees
No one assigned
Labels
area: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@huozhi