Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Add handling for app-paths-manifest #8098

Merged
merged 8 commits into from
Aug 22, 2022
Merged

[next] Add handling for app-paths-manifest #8098

merged 8 commits into from
Aug 22, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 7, 2022

This adds handling for the app outputs and adds initial tests to ensure it is working as expected.

Related Issues

x-ref: vercel/next.js#38420

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@ijjk ijjk added semver: patch PR contains bug fixes area: next labels Jul 7, 2022
@ijjk ijjk marked this pull request as ready for review July 7, 2022 21:05
@ijjk ijjk requested a review from timneutkens July 7, 2022 21:05
@codecov
Copy link

codecov bot commented Jul 8, 2022 •
edited

Codecov Report

Merging #8098 (14b5daa) into main (f03c947) will not change coverage.
The diff coverage is n/a.

❗ Current head 14b5daa differs from pull request most recent head 5a04b53. Consider uploading reports for the commit 5a04b53 to get more accurate results

@@     Coverage Diff      @@
##   main   #8098   +/-   ##
============================
============================

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot removed the semver: patch PR contains bug fixes label Jul 15, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jul 15, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['semver-major', 'semver-minor', 'semver-patch'] label.

styfle
styfle reviewed Jul 28, 2022
View reviewed changes
packages/next/src/index.ts Outdated Show resolved Hide resolved
styfle
styfle reviewed Jul 28, 2022
View reviewed changes
packages/next/src/index.ts Outdated Show resolved Hide resolved
@ijjk ijjk marked this pull request as draft August 2, 2022 21:59
@ijjk
Merge branch 'main' into ijjk/app-dir-support
4afc499 
# Conflicts:
#	packages/next/src/server-build.ts
#	test/lib/run-build-lambda.js
@ijjk
apply suggestions
8953047
@ijjk ijjk marked this pull request as ready for review August 22, 2022 14:31
@ijjk ijjk added the semver: patch PR contains bug fixes label Aug 22, 2022
styfle
styfle reviewed Aug 22, 2022
View reviewed changes
packages/next/src/index.ts Outdated Show resolved Hide resolved
@ijjk ijjk requested a review from styfle August 22, 2022 18:54
@ijjk ijjk merged commit e34858d into main Aug 22, 2022
@ijjk ijjk deleted the ijjk/app-dir-support branch August 22, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

Assignees
No one assigned
Labels
area: next semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @TooTallNate @styfle