Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turborepo): Persistent tasks in watch mode #8107

Merged
merged 1 commit into from May 9, 2024

Conversation

NicholasLYang
Copy link
Contributor

@NicholasLYang NicholasLYang commented May 7, 2024

Description

Fixing persistent tasks in watch mode. I accidentally reversed the dependency relation which created a circular dependency which in turn caused a deadlock.

Testing Instructions

Try out turbo watch dev in create turbo

Closes TURBO-3020

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:46pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:46pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 7, 2024 10:46pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 7, 2024 10:46pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 7, 2024 10:46pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 7, 2024 10:46pm
examples-native-web ⬜️ Ignored (Inspect) May 7, 2024 10:46pm
examples-svelte-web ⬜️ Ignored (Inspect) May 7, 2024 10:46pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 7, 2024 10:46pm
examples-vite-web ⬜️ Ignored (Inspect) May 7, 2024 10:46pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NicholasLYang and the rest of your teammates on Graphite Graphite

@NicholasLYang NicholasLYang changed the title Got the dependency order wrong fix(turborepo): Persistent tasks in watch mode May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 7, 2024

🟢 CI successful 🟢

Thanks

@orjan
Copy link

orjan commented May 8, 2024

Will this fix make sure that a persistent task is restarted when a dependency has been changed?

@NicholasLYang
Copy link
Contributor Author

@orjan, no, the assumption is that persistent tasks are self healing, i.e. if a dependency changes, the persistent task will figure that out without having to be re-run. Persistent tasks are only re-run if we need to do a full rediscovery, which happens if the underlying turbo graph changes.

@orjan
Copy link

orjan commented May 9, 2024

@orjan, no, the assumption is that persistent tasks are self healing, i.e. if a dependency changes, the persistent task will figure that out without having to be re-run. Persistent tasks are only re-run if we need to do a full rediscovery, which happens if the underlying turbo graph changes.

Thanks for the explanation, it explains why I wasn't able restart the task here:
#8095

@NicholasLYang NicholasLYang merged commit 021f9a0 into main May 9, 2024
56 checks passed
@NicholasLYang NicholasLYang deleted the fix/persistent-tasks-in-watch branch May 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants