New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(turborepo): Persistent tasks in watch mode #8107
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on Graphite |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
Will this fix make sure that a persistent task is restarted when a dependency has been changed? |
@orjan, no, the assumption is that persistent tasks are self healing, i.e. if a dependency changes, the persistent task will figure that out without having to be re-run. Persistent tasks are only re-run if we need to do a full rediscovery, which happens if the underlying turbo graph changes. |
Thanks for the explanation, it explains why I wasn't able restart the task here: |
Description
Fixing persistent tasks in watch mode. I accidentally reversed the dependency relation which created a circular dependency which in turn caused a deadlock.
Testing Instructions
Try out
turbo watch dev
in create turboCloses TURBO-3020