Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust toolchain to nightly-2023-09-21 #6002

Merged
merged 9 commits into from Sep 22, 2023
Merged

Update rust toolchain to nightly-2023-09-21 #6002

merged 9 commits into from Sep 22, 2023

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Sep 22, 2023 •
edited by padmaia

This:

Closes WEB-1635

@wbinnssmith
Update rust toolchain to nightly-2023-09-21
747eb54 
This:

- Updates to the latest api change for `StdError` in `error_generic_member_access` rust-lang/rust#99301
- Updates `pathfinder_simd` for compatiblity
- Updates other crates for compatibility with Next.js
@wbinnssmith wbinnssmith requested review from a team as code owners September 22, 2023 00:19
orca-security-us[bot]
orca-security-us bot reviewed Sep 22, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turborepo Rust tests

See workflow summary for details

@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 5:29am
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 5:29am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 5:29am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 5:29am

@github-actions
Copy link
Contributor

Linux Benchmark for 8c890af

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5843.68µs ± 47.44µs 5894.35µs ± 77.78µs +0.87%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5372.36µs ± 35.07µs 5551.48µs ± 303.65µs +3.33%
bench_startup/Turbopack CSR/1000 modules 985.88ms ± 1.73ms 985.21ms ± 1.29ms -0.07%

@mehulkar mehulkar removed their request for review September 22, 2023 03:27
@github-actions
Copy link
Contributor

Linux Benchmark for e00f907

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5314.33µs ± 25.48µs 5329.26µs ± 30.65µs +0.28%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4946.41µs ± 25.15µs 5124.47µs ± 190.30µs +3.60%
bench_startup/Turbopack CSR/1000 modules 994.44ms ± 2.25ms 991.92ms ± 3.93ms -0.25%

@github-actions
Copy link
Contributor

Linux Benchmark for e9f7118

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5276.20µs ± 30.49µs 5310.10µs ± 21.93µs +0.64%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4965.00µs ± 29.82µs 5037.92µs ± 101.35µs +1.47%
bench_startup/Turbopack CSR/1000 modules 976.70ms ± 0.79ms 983.66ms ± 3.92ms +0.71%

@wbinnssmith wbinnssmith merged commit ad585d3 into main Sep 22, 2023
63 of 69 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/nightly-2023-09-21 branch September 22, 2023 17:57
Zertsov pushed a commit that referenced this pull request Sep 27, 2023
@wbinnssmith @Zertsov
Update rust toolchain to nightly-2023-09-21 (#6002)
b1ff9f4 
This:

- Updates to the latest api change for `StdError` in
`error_generic_member_access` rust-lang/rust#99301
- Updates `pathfinder_simd` for compatiblity
- Updates other crates for compatibility with Next.js


Closes WEB-1635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us left review comments

@kwonoj kwonoj kwonoj approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci created-by: turbopack owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wbinnssmith @kwonoj