feat(next-dev): align devserver cli options to napi bindings #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kwonoj is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
kwonoj
force-pushed
the
feat-cli-options
branch
from
36166ce
to
5b22aa8
Compare
Brooooooklyn
approved these changes
Nov 11, 2022
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes few napi-only bindings options to next-dev cli as well.
Aligned with vercel/next.js#42656, attempts to allow to run custom binary with next.js transparently. It is mostly for the easier CI testing (pick up next.js, run its test with turbopack PR) however also allows local dev testing bit easier since it is possible to avoid to rebuild napi bindings per each turbopack changes.
Cli options are not stablized yet, so I expect this won't cause noticeable breaking changes in the future. It'll be breaking changes, but this is more close to internal api currently.