Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error retry should be handled by global revalidator instead of local revalidation function #2415

Merged
merged 8 commits into from
Feb 14, 2023

Conversation

promer94
Copy link
Collaborator

@promer94 promer94 commented Feb 8, 2023

close #2412 which was introduced in #2338

Problem

function Demo() {
   useSWR('/key', () => { throw new Error('error') })
   useSWR('/key', () => { throw new Error('error') })
}

Previously, if we have two swr hook, There will be two retry task pushed into queue. If first hook unmount, the error retry won't stop because of another task.

But after #2338, only the first mouted swr hook will schedule an error retry task using it own revalidate function.
If the first hook unmount, the revalidate function will become inactive because of

swr/core/use-swr.ts

Lines 263 to 270 in f7004ac

if (
!key ||
!currentFetcher ||
unmountedRef.current ||
getConfig().isPaused()
) {
return false
}

Solution

Instead of using local revalidate function for error retry, swr should always use the global event revalidator since it would be always active.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61f7564:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration
isValidating-infinite-render (forked) Issue #2412

@promer94 promer94 marked this pull request as draft February 8, 2023 16:07
@promer94 promer94 changed the title Fix: erroy retry Fix: error retry Feb 8, 2023
@promer94 promer94 changed the title Fix: error retry fix: Error retry should be handled by global revalidator instead of local revalidation function Feb 8, 2023
@promer94 promer94 marked this pull request as ready for review February 9, 2023 04:02
@promer94 promer94 requested a review from koba04 February 9, 2023 16:52
@shuding shuding merged commit a74f886 into vercel:main Feb 14, 2023
@promer94 promer94 deleted the error-retry branch February 14, 2023 08:17
renovate bot added a commit to Unleash/unleash that referenced this pull request Mar 9, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [swr](https://swr.vercel.app)
([source](https://togithub.com/vercel/swr)) | [`2.0.3` ->
`2.0.4`](https://renovatebot.com/diffs/npm/swr/2.0.3/2.0.4) |
[![age](https://badges.renovateapi.com/packages/npm/swr/2.0.4/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/swr/2.0.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/swr/2.0.4/compatibility-slim/2.0.3)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/swr/2.0.4/confidence-slim/2.0.3)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/swr</summary>

### [`v2.0.4`](https://togithub.com/vercel/swr/releases/tag/v2.0.4)

[Compare
Source](https://togithub.com/vercel/swr/compare/v2.0.3...v2.0.4)

#### Patches

- build: fix release job condition by
[@&#8203;huozhi](https://togithub.com/huozhi) in
[vercel/swr#2392
- types: fix some mutation type issue by
[@&#8203;promer94](https://togithub.com/promer94) in
[vercel/swr#2421
- fix: Error retry should be handled by global revalidator instead of
local revalidation function by
[@&#8203;promer94](https://togithub.com/promer94) in
[vercel/swr#2415
- fix: ensure initCache setter function stays within bounds of
subscriptions by [@&#8203;lfbergee](https://togithub.com/lfbergee) in
[vercel/swr#2411

#### Misc

- test: stream ssr e2e by
[@&#8203;promer94](https://togithub.com/promer94) in
[vercel/swr#2395
- test: fix an act warning by
[@&#8203;koba04](https://togithub.com/koba04) in
[vercel/swr#2403

#### New Contributors

- [@&#8203;lfbergee](https://togithub.com/lfbergee) made their first
contribution in
[vercel/swr#2411

**Full Changelog**:
vercel/swr@v2.0.3...v2.0.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTkuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1OS4wIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot pushed a commit to kula-app/OnLaunch that referenced this pull request Mar 15, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [swr](https://swr.vercel.app) ([source](https://togithub.com/vercel/swr)) | [`2.0.3` -> `2.1.0`](https://renovatebot.com/diffs/npm/swr/2.0.3/2.1.0) | [![age](https://badges.renovateapi.com/packages/npm/swr/2.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/swr/2.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/swr/2.1.0/compatibility-slim/2.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/swr/2.1.0/confidence-slim/2.0.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/swr</summary>

### [`v2.1.0`](https://togithub.com/vercel/swr/releases/tag/v2.1.0)

[Compare Source](https://togithub.com/vercel/swr/compare/v2.0.4...v2.1.0)

#### Feature

-   Subscription mode by [@&#8203;huozhi](https://togithub.com/huozhi) in [vercel/swr#1263
-   parallel option for useSWRInfinite by [@&#8203;koba04](https://togithub.com/koba04) in [vercel/swr#2404

Checkout [subscription docs](https://swr.vercel.app/docs/subscription) and [useSWRInfinite parallel fetching docs](https://swr.vercel.app/docs/pagination#parallel-fetching-mode) for more details

#### Patches

-   fix: use the latest config in useSWRMutation by [@&#8203;koba04](https://togithub.com/koba04) in [vercel/swr#2468
-   Fix: type support for suspense and fallbackData([#&#8203;2396](https://togithub.com/vercel/swr/issues/2396)) by [@&#8203;taro-28](https://togithub.com/taro-28) in [vercel/swr#2452
-   Error should be reset when new data comes by [@&#8203;huozhi](https://togithub.com/huozhi) in [vercel/swr#2472
-   fix: avoid creating new snapshot if cache is not updated at client during streaming by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2475
-   refactor: initialize the cache only on first access by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2479

#### Misc

-   ci: fix publish workflow by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2453
-   ci: faster e2e test by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2428
-   test: add a test for keepPreviousData without changing key by [@&#8203;koba04](https://togithub.com/koba04) in [vercel/swr#2470
-   Always assume subscriptions will return sub count from current key by [@&#8203;huozhi](https://togithub.com/huozhi) in [vercel/swr#2460
-   test: Fix flaky e2e test by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2476
-   chore: Add subscription example by [@&#8203;huozhi](https://togithub.com/huozhi) in [vercel/swr#2480

#### New Contributors

-   [@&#8203;taro-28](https://togithub.com/taro-28) made their first contribution in [vercel/swr#2452

**Full Changelog**: vercel/swr@v2.0.4...v2.1.0

### [`v2.0.4`](https://togithub.com/vercel/swr/releases/tag/v2.0.4)

[Compare Source](https://togithub.com/vercel/swr/compare/v2.0.3...v2.0.4)

#### Patches

-   build: fix release job condition by [@&#8203;huozhi](https://togithub.com/huozhi) in [vercel/swr#2392
-   types: fix some mutation type issue by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2421
-   fix: Error retry should be handled by global revalidator instead of local revalidation function by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2415
-   fix: ensure initCache setter function stays within bounds of subscriptions by [@&#8203;lfbergee](https://togithub.com/lfbergee) in [vercel/swr#2411

#### Misc

-   test: stream ssr e2e by [@&#8203;promer94](https://togithub.com/promer94) in [vercel/swr#2395
-   test: fix an act warning by [@&#8203;koba04](https://togithub.com/koba04) in [vercel/swr#2403

#### New Contributors

-   [@&#8203;lfbergee](https://togithub.com/lfbergee) made their first contribution in [vercel/swr#2411

**Full Changelog**: vercel/swr@v2.0.3...v2.0.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kula-app/OnLaunch).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNS44LjMifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Error retry will be disable if first hook unmount
3 participants