Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #1968

Merged
merged 4 commits into from May 15, 2022
Merged

Bug fixes #1968

merged 4 commits into from May 15, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented May 14, 2022

This PR gets rid of the as SWRInfiniteResponse<Data, Error> casting from swr/infinite. Also, it ensures that setSize and mutate returned from useSWRInfinite are strictly promises as the typings required (a bug), and fixes MutatorOptions<Data> which should be MutatorOptions<Data[]> instead.

@shuding shuding requested a review from huozhi as a code owner May 14, 2022 23:44
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 921f93a:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking comments, LGTM

infinite/index.ts Outdated Show resolved Hide resolved
infinite/index.ts Show resolved Hide resolved
@shuding shuding merged commit 93f86a7 into main May 15, 2022
@shuding shuding deleted the shu/a983 branch May 15, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants