build: Mangle internal export names #1963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b5cc06:
|
huozhi
reviewed
May 13, 2022
huozhi
approved these changes
May 13, 2022
huozhi
reviewed
May 13, 2022
| @@ -0,0 +1,31 @@ | |||
| export const enum InternalUtils { | |||
There was a problem hiding this comment.
maybe explain why we need to have this as comment here, to help contributors understand better this is for size compression purpose
huozhi
changed the title
|
Closing for now as most of bundlers are already handling this today. For the other cases that modules can’t be bundled together (bundleless solutions, or ending up in different chunks somehow), we will wait and see if it has an impact or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1962 we added a shared internal module for all subpath imports to use. However the named exports can't be minified (by many bundlers) because they're across modules. Here we are using TypeScript enums to ensure that 1) these names can be minified, and 2) we can still import the correct utils with typings easily.
This decreases the bundle size by 800+ bytes (minified) for just
'swr', and will probably save more if other subpaths are used such as'swr/infinite'.