Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mutate args for useSWRInfinite hook #1947

Merged
merged 8 commits into from May 14, 2022
Merged

fix: mutate args for useSWRInfinite hook #1947

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9aa2373
fix: mutate args for useSWRInfinite hook
May 1, 2022
9660485
Add swr infinite test for revalidation with arguments
May 1, 2022
b6f4781
Add swr infinite test for non-revalidation with arguments
May 1, 2022
a322130
Rename swr infinite mutate test case
May 3, 2022
c0d8d7a
Update type for infite mutate args
May 14, 2022
9644a6f
Merge branch 'main' of https://github.com/sanjeev29/swr into fix/swr-…
May 14, 2022
fd2d3db
Include 'MutatorOptions' import
May 14, 2022
656691d
Merge branch 'main' of https://github.com/sanjeev29/swr into fix/swr-…
May 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion infinite/index.ts
View file
Open in desktop
Expand Up @@ -180,9 +180,13 @@ export const infinite = (<Data, Error>(useSWRNext: SWRHook) =>
]
) => {
const data = args[0]

// When passing as a boolean, it's explicitly used to disable/enable
// revalidation.
const options = typeof args[1] === 'boolean' ? {revalidate: args[1]} : args[1] || {}

// Default to true.
const shouldRevalidate = args[1] !== false
const shouldRevalidate = options.revalidate !== false

// It is possible that the key is still falsy.
if (!infiniteKey) return
Expand Down