Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: output mutation cjs bundle with named exports #1926

Merged
merged 1 commit into from Apr 16, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 16, 2022

Fixes #1923

rollup default auto output.exports detection decide to output mutation as module.exports which is different from other subpath imports, I sticked the config to named exports in bunchee

also export the SWRMutationHook type

@huozhi huozhi requested a review from shuding as a code owner April 16, 2022 10:12
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec66ebd:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding shuding merged commit 40a61fd into main Apr 16, 2022
@shuding shuding deleted the build/mutation branch April 16, 2022 10:18
himanshiLt pushed a commit to himanshiLt/swr that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swr mutation cjs output is using module.exports instead of exports.default
2 participants