Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: fix type error on SWRConfig #1913

Merged
merged 1 commit into from Apr 8, 2022
Merged

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Apr 8, 2022

DefinitelyTyped/DefinitelyTyped#56210 (comment)

In @types/react 18, they remove children type in FC by default

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b385dd9:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration

@shuding
Copy link
Member

shuding commented Apr 8, 2022

Thanks @himself65!

@shuding shuding merged commit db93f66 into vercel:main Apr 8, 2022
@himself65 himself65 deleted the type-fix branch April 8, 2022 16:24
@Moinax
Copy link

Moinax commented Apr 8, 2022

Hi everyone,

When do you plan to do a release with this fix ?

Thanks in advance,

@shuding
Copy link
Member

shuding commented Apr 9, 2022

@Moinax Yes I will cut a release today.

@shuding
Copy link
Member

shuding commented Apr 10, 2022

Published v1.3.0.

@Moinax
Copy link

Moinax commented Apr 11, 2022

Published v1.3.0.

Thanks a lot @shuding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants