Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the documentation of the mutate options in the Mutation page #324

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

koba04
Copy link
Collaborator

@koba04 koba04 commented Aug 5, 2022

mutate now has multiple options like revalidate, optimisticUpdate, etc. But the explanations are in the Optimistic Updates section on the Mutation page.
It's hard to find the documentation of the options, so I've extracted the explanations at the top of the Mutation page.

I've also changed the argument name of the mutation options to be clearer.

I'm not sure why the docs of pt-BR have many diffs even though I don't make such changes...

The actual diff is https://github.com/vercel/swr-site/pull/324/files?w=1

Description

  • Adding new page
  • Updating existing documentation
  • Other updates

@vercel
Copy link

vercel bot commented Aug 5, 2022

@koba04 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@koba04 koba04 changed the base branch from main to v2 August 13, 2022 13:29
@koba04 koba04 changed the base branch from v2 to main August 13, 2022 13:30
@koba04
Copy link
Collaborator Author

koba04 commented Aug 13, 2022

I'd like to merge this before #325 gets merged.

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@shuding shuding merged commit fd34ba1 into vercel:main Aug 23, 2022
@koba04 koba04 deleted the update-mutate-options branch August 30, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants