Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update table of content in readme + more details about SSR #824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zwyx
Copy link

@Zwyx Zwyx commented Jan 4, 2023

I updated the table of content, and I'd like to clarify a sentence about SSR, I'll write more in a comment just bellow.

@Zwyx Zwyx requested a review from ijjk as a code owner January 4, 2023 13:00
@@ -346,7 +358,7 @@ Please keep in mind that constants defined outside of the component scope are tr
- `registry.styles()` will return the array of react components for style tags.
- `registry.flush()` can clean the existing styles in the registry, it's optional for SSR when you have a standalone registry for each SSR render.

> Next.js 12 integrates with `styled-jsx` v5 and manages the registry for you.
> Next.js 12 and over integrates with `styled-jsx` v5 and manages the registry for you.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence isn't very clear to me. Does it mean that we do not have to care at all about SSR if we are using Next 12+ because it's all done automatically?

@Zwyx Zwyx changed the title Update table of content + more details about SSR Update table of content in readme + more details about SSR Jan 4, 2023
@Zwyx Zwyx changed the title Update table of content in readme + more details about SSR docs: update table of content in readme + more details about SSR Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant