Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mark @babel/core as optional peer dependency #739

Merged
merged 4 commits into from
Aug 30, 2021
Merged

fix: mark @babel/core as optional peer dependency #739

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
303d9c9
Fixes https://github.com/vercel/styled-jsx/issues/736
spa5k Aug 27, 2021
d2b708a
moving babel back to dev deps and adding peerdependencies meta option
spa5k Aug 28, 2021
735848f
Update package.json
spa5k Aug 28, 2021
8916975
Merge branch 'master' into patch-1
huozhi Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
}
},
"dependencies": {
"@babel/core": "7.12.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This jsx plugin should use @babel/core on user side so we don't want it to become dependency.

We can add the meta field to package.json to declare it as optional

"peerDependenciesMeta": {
  "@babel/core": {
    "optional": true
  }
}

Copy link
Contributor Author

@spa5k spa5k Aug 28, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, did not knew this option existed.

"@babel/plugin-syntax-jsx": "7.14.5",
"@babel/types": "7.15.0",
"convert-source-map": "1.7.0",
Expand All @@ -70,7 +71,6 @@
},
"devDependencies": {
"@babel/cli": "7.12.1",
"@babel/core": "7.12.3",
"@babel/plugin-proposal-object-rest-spread": "7.12.1",
"@babel/plugin-transform-arrow-functions": "7.12.1",
"@babel/plugin-transform-modules-commonjs": "7.12.1",
Expand Down