Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opt in insertion effect hook when available #753

Merged
merged 4 commits into from Oct 22, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 19, 2021

ref: new experimental hook for css lib reactwg/react-18#110

Related issue: #752
Related prs: #484, #720

@huozhi huozhi requested a review from shuding October 20, 2021 10:22
src/style.js Outdated Show resolved Hide resolved
@huozhi huozhi requested a review from shuding October 20, 2021 13:12
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use the desired name explicitly but with a comment explaining the fallback.

src/style.js Outdated Show resolved Hide resolved
src/style.js Outdated Show resolved Hide resolved
@timneutkens timneutkens merged commit e0e253c into vercel:beta Oct 22, 2021
@github-actions
Copy link

🎉 This PR is included in version 5.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants