Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade styled-jsx for react 18 improvement #30179

Merged
merged 2 commits into from Oct 23, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 22, 2021

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Oct 23, 2021

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update-styled-jsx Change
buildDuration 12.5s 14.6s ⚠️ +2.1s
buildDurationCached 2.8s 2.9s ⚠️ +11ms
nodeModulesSize 196 MB 196 MB ⚠️ +358 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js update-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 2.911 2.899 -0.01
/ avg req/sec 858.95 862.46 +3.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.385 1.384 0
/error-in-render avg req/sec 1805.07 1806.29 +1.22
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js update-styled-jsx Change
651.cd440d20..0b23.js gzip 2.96 kB 2.96 kB
831.695e33f6..205f.js gzip 179 B 179 B
framework-89..a097.js gzip 42.2 kB 42.2 kB
main-dcb1764..4cad.js gzip 26.1 kB 26.1 kB
webpack-f09b..493e.js gzip 1.47 kB 1.47 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update-styled-jsx Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js update-styled-jsx Change
_app-9fb8765..c13d.js gzip 979 B 979 B
_error-d828d..2954.js gzip 3.06 kB 3.06 kB
amp-5388d1f5..4ce9.js gzip 551 B 551 B
css-10424225..367a.js gzip 329 B 329 B
dynamic-9821..3cd4.js gzip 2.67 kB 2.67 kB
head-1df323b..d261.js gzip 2.32 kB 2.32 kB
hooks-ab0016..b093.js gzip 917 B 917 B
image-acc140..4699.js gzip 5.86 kB 5.86 kB
index-95c8cb..6970.js gzip 260 B 260 B
link-05c99e7..35ec.js gzip 1.66 kB 1.66 kB
routerDirect..6659.js gzip 319 B 319 B
script-d94ba..ed05.js gzip 386 B 386 B
withRouter-7..8b2e.js gzip 317 B 317 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 19.8 kB 19.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update-styled-jsx Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update-styled-jsx Change
index.html gzip 536 B 536 B
link.html gzip 548 B 548 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update-styled-jsx Change
buildDuration 6.1s 6.1s ⚠️ +30ms
buildDurationCached 2.8s 2.8s ⚠️ +32ms
nodeModulesSize 196 MB 196 MB ⚠️ +358 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js update-styled-jsx Change
/ failed reqs 0 0
/ total time (seconds) 2.923 2.903 -0.02
/ avg req/sec 855.41 861.18 +5.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.429 1.391 -0.04
/error-in-render avg req/sec 1749.19 1797.13 +47.94
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js update-styled-jsx Change
450.fd3ad245..022b.js gzip 179 B 179 B
675-bdcdd2c1..095f.js gzip 13.8 kB 13.8 kB
framework-13..70b0.js gzip 50.8 kB 50.8 kB
main-b530c3e..1d2b.js gzip 36.5 kB 36.5 kB
webpack-a7f2..2650.js gzip 1.63 kB 1.63 kB
Overall change 103 kB 103 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update-styled-jsx Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js update-styled-jsx Change
_app-ae91bc3..d985.js gzip 1.33 kB 1.33 kB
_error-273ac..9ef0.js gzip 180 B 180 B
amp-5f9a7694..99ce.js gzip 315 B 315 B
css-3a1b2477..df1e.js gzip 330 B 330 B
dynamic-e04a..a1b5.js gzip 2.79 kB 2.79 kB
head-7f600d0..daa3.js gzip 356 B 356 B
hooks-bd8c02..0730.js gzip 638 B 638 B
image-6365b7..7506.js gzip 536 B 536 B
index-80be94..e89f.js gzip 262 B 262 B
link-4ee1ea7..8745.js gzip 2.22 kB 2.22 kB
routerDirect..c4aa.js gzip 325 B 325 B
script-67da0..49e6.js gzip 390 B 390 B
withRouter-2..2409.js gzip 322 B 322 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update-styled-jsx Change
_buildManifest.js gzip 477 B 477 B
Overall change 477 B 477 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update-styled-jsx Change
index.html gzip 536 B 536 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 545b176

@timneutkens timneutkens merged commit 79c25a4 into canary Oct 23, 2021
@timneutkens timneutkens deleted the update-styled-jsx branch October 23, 2021 06:07
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants