Add support for PFX or PKCS12 encoded certificates

[schemburkar]

Added support for PFX or PKCS12 encoded certificates by providing additional command line parameters

e.g.

$ serve -l 5000 --ssl-cert "cert.pfx" --ssl-pass "password.txt" --ssl-format "pfx"

New Command line options

--ssl-format: Optional format of the SSL/TLS certificate. Supported formats: pem (default) and pfx

When --ssl-format is omitted, the default format (pem) will be used.

Edit: --ssl-pass is supported for both pem and pfx formats.
Edit: Removed --ssl-passphrase in favor of existing --ssl-pass option

[schemburkar]

Does anyone from the contributors or maintainers have any comments or help for PR to proceed? I will be glad to assist.

[ghost]

Actually, I have need of specifying the passphrase even when it's a crt/key combo. This PR doesn't seem to account for that, am I missing something? @schemburkar

[schemburkar]

Actually, I have need of specifying the passphrase even when it's a crt/key combo. This PR doesn't seem to account for that, am I missing something? @schemburkar

1a0a60d Addresses your issue and adds support for passphrase even for a cert/key format.

[leerob]

Is this a common use case? If so, could you add documentation for this?

[schemburkar]

Is this a common use case? If so, could you add documentation for this?

@leerob When on Windows, I usually use the default PFX certs for SSL. Before the PR I could not use them with serve, and had to either keep https off or use another formats. Using another format means conversions which adds a step.
With PFX certificate support I can continue to use serve and my certificate easily.

When testing dotnet APIs, usually it needs PFX certs too, so having one format across tools is bonus

Does this answer your question? If not let me know

[dakotaJang]

I hoping this gets implemented as well.
It would simply some instructions for setting up if I can leverage the .pfx file that gets generated in the dotnet flow.
To avoid confusion i think it might be better to introduce new flags like --ssl-pfx instead of introducing --ssl-format and reusing --ssl-cert for pfx.

[an-dr-eas-k]

Also like the suggestion of @dakotaJang and anyhow would be glad if it gets merged

[schemburkar]

@dakotaJang @an-dr-eas-k would be glad to merge this PR. I'm willing to make further changes like @dakotaJang suggestion. Need the vercel/serve team to give their interest or suggestion here before I make any further changes.

Until there is a plan to get this merged, I have not made any changes or rebased against main branch.

Hope this helps

[an-dr-eas-k]

also started myself addressing @dakotaJang suggestion, see here https://github.com/an-dr-eas-k/serve

[leerob]

We are rewriting the project in TypeScript - if you are still interested in contributing, could you open a PR against this branch? #706

Thank you! (Also posting to #673)