Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @next/package-manager-utils to unify package manager utilities across the repo. #65096

Draft
wants to merge 5 commits into
base: canary
Choose a base branch
from

Conversation

Ethan-Arrowood
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood commented Apr 26, 2024

I've noticed that we have duplicate, inconsistent, and untested logic for package manager utilities. This PR creates a new package (for internal use only?) that unifies these utilities in a single location. This enables us to make updates to them easier, have consistent usage across the repo, and properly test their functionality. Today we rely on our integration/e2e testing only and they do not cover all cases such as the issue I fixed here: #64418.

The files in consideration include:

The plan is to introduce these changes in parts. First, I'd like to unify the major overlap (get-pkg-manager, is-online, and install). Afterwards, I'll work on moving some of the other utilities over. I also need to look over the remaining packages and see if any of them have similar logic to include in this work.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Apr 26, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Ethan-Arrowood and the rest of your teammates on Graphite Graphite

@Ethan-Arrowood Ethan-Arrowood changed the title temp Create @next/package-manager-utils to unify package manager utilities across the repo. Apr 26, 2024
@Ethan-Arrowood Ethan-Arrowood marked this pull request as ready for review April 26, 2024 19:17
@Ethan-Arrowood Ethan-Arrowood marked this pull request as draft April 26, 2024 19:17
@ijjk
Copy link
Member

ijjk commented Apr 26, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
buildDuration 17s 15.4s N/A
buildDurationCached 8.8s 7.7s N/A
nodeModulesSize 360 MB 360 MB
nextStartRea..uration (ms) 426ms 430ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.09 kB 5.09 kB N/A
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 230 B 229 B N/A
main-HASH.js gzip 31.5 kB 31.5 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4 kB 4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
index.html gzip 528 B 526 B N/A
link.html gzip 541 B 539 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
edge-ssr.js gzip 94.7 kB 94.7 kB N/A
page.js gzip 181 kB 181 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 995 B 995 B
Next Runtimes
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.4 kB 98.4 kB
app-page-tur..prod.js gzip 99.9 kB 99.9 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93 kB 93 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 962 kB 962 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js add-next-package-manager-utils Change
0.pack gzip 1.62 MB 1.62 MB ⚠️ +617 B
index.pack gzip 112 kB 112 kB ⚠️ +211 B
Overall change 1.73 MB 1.73 MB ⚠️ +828 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: 6d8233d

Copy link

socket-security bot commented Apr 26, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/execa@8.0.1 environment +10 249 kB ehmicky

View full report↗︎

Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
@ijjk
Copy link
Member

ijjk commented Apr 29, 2024

Failing test suites

Commit: edc7b79

TURBOPACK=1 pnpm test-start test/e2e/app-dir/app-client-cache/client-cache.test.ts (turbopack)

  • app dir client cache semantics > prefetch={true} > should prefetch again after 5 mins if the link is visible again
Expand output

● app dir client cache semantics › prefetch={true} › should prefetch again after 5 mins if the link is visible again

TIMED OUT: success

fail

undefined

  686 |
  687 |   if (hardError) {
> 688 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  689 |   }
  690 |   return false
  691 | }

  at check (lib/next-test-utils.ts:688:11)
  at Object.<anonymous> (e2e/app-dir/app-client-cache/client-cache.test.ts:156:9)

Read more about building and testing Next.js in contributing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants