Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: rename source map prefix #64965

Merged
merged 2 commits into from May 1, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 24, 2024

What?

see vercel/turbo#8034

Why?

How?

@sokra sokra marked this pull request as draft April 24, 2024 10:18
@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team type: next labels Apr 24, 2024
@ijjk
Copy link
Member

ijjk commented Apr 24, 2024

Failing test suites

Commit: c265c8e

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/rsc-basic/rsc-basic.test.ts (PPR)

  • app dir - rsc basics > should be able to navigate between rsc routes
Expand output

● app dir - rsc basics › should be able to navigate between rsc routes

request.allHeaders: Target page, context or browser has been closed

  144 |         page.on('request', (request) => {
  145 |           requestsCount++
> 146 |           return request.allHeaders().then((headers) => {
      |                          ^
  147 |             if (
  148 |               headers['RSC'.toLowerCase()] === '1' &&
  149 |               // Prefetches also include `RSC`

  at Page.allHeaders (e2e/app-dir/rsc-basic/rsc-basic.test.ts:146:26)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 24, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
buildDuration 21.8s 19.2s N/A
buildDurationCached 10.9s 9.4s N/A
nodeModulesSize 360 MB 360 MB
nextStartRea..uration (ms) 496ms 484ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
1103-HASH.js gzip 31.9 kB 31.9 kB N/A
1a9f679d-HASH.js gzip 53.5 kB 53.5 kB N/A
335-HASH.js gzip 5.09 kB 5.09 kB N/A
7953.HASH.js gzip 169 B 169 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 231 B 230 B N/A
main-HASH.js gzip 31.5 kB 31.5 kB N/A
webpack-HASH.js gzip 1.65 kB 1.65 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
_app-HASH.js gzip 192 B 193 B N/A
_error-HASH.js gzip 192 B 193 B N/A
amp-HASH.js gzip 507 B 511 B N/A
css-HASH.js gzip 341 B 343 B N/A
dynamic-HASH.js gzip 2.52 kB 2.52 kB
edge-ssr-HASH.js gzip 266 B 265 B N/A
head-HASH.js gzip 362 B 365 B N/A
hooks-HASH.js gzip 392 B 392 B
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.69 kB 2.7 kB N/A
routerDirect..HASH.js gzip 329 B 328 B N/A
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 324 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4 kB 4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
index.html gzip 526 B 526 B
link.html gzip 540 B 541 B N/A
withRouter.html gzip 523 B 525 B N/A
Overall change 526 B 526 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
edge-ssr.js gzip 94.7 kB 94.7 kB N/A
page.js gzip 181 kB 181 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
middleware-b..fest.js gzip 622 B 625 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.7 kB 25.7 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 995 B 995 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 157 kB 157 kB
app-page.run..prod.js gzip 93.1 kB 93.1 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route.ru...dev.js gzip 21.3 kB 21.3 kB
app-route.ru..prod.js gzip 15 kB 15 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.1 kB 22.1 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 962 kB 962 kB
build cache
vercel/next.js canary vercel/next.js sokra/rename-source-map-prefix Change
0.pack gzip 1.62 MB 1.62 MB N/A
index.pack gzip 113 kB 113 kB N/A
Overall change 0 B 0 B
Diff details
Diff for edge-ssr.js

Diff too large to display

Commit: c265c8e

@sokra sokra force-pushed the sokra/rename-source-map-prefix branch from 63a1224 to c265c8e Compare April 30, 2024 15:20
@sokra sokra marked this pull request as ready for review April 30, 2024 15:21
@sokra sokra enabled auto-merge (squash) May 1, 2024 04:58
@sokra sokra merged commit 77706b6 into canary May 1, 2024
81 checks passed
@sokra sokra deleted the sokra/rename-source-map-prefix branch May 1, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants