New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite with-dotenv example #4924

Merged

timneutkens merged 1 commit into vercel:canary from HaNdTriX:with-dotenv

Aug 8, 2018

Contributor

HaNdTriX commented Aug 8, 2018 •

edited

Issue

I decided to rewrite the with-dotenv using dotenv-webpack example because:

changes doesn't get applied (with-dotenv example when changing .env changes doesn't get applied #4748, plugin works only once brysgo/babel-plugin-inline-dotenv#13)
the production mode doesn't work at all
this approach has already been used in the examples/relay-modern
it is documented by webpack

Alternatives

remove/deprecate example
fix babel-plugin-inline-dotenv

Related

Closes: #4748

HaNdTriX force-pushed the with-dotenv branch from b577db2 to 39113e1 Compare

August 8, 2018 15:37


          Rewrite with-dotenv example

66676a7

HaNdTriX force-pushed the with-dotenv branch from 39113e1 to 66676a7 Compare

August 8, 2018 15:37

timneutkens approved these changes

View reviewed changes

timneutkens merged commit d3f1fa6 into vercel:canary

Member

timneutkens commented Aug 8, 2018

Thanks!

HaNdTriX deleted the with-dotenv branch

August 8, 2018 16:01

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.