Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forwarding props to no ssr dynamic #43901

Merged
merged 2 commits into from Dec 9, 2022
Merged

fix: forwarding props to no ssr dynamic #43901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdce6a6
fix: forwarding props to no ssr dynamic
huozhi Dec 9, 2022
b3103fe
Merge branch 'canary' into fix/dynamic-props
kodiakhq[bot] Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/shared/lib/dynamic.tsx
View file
Open in desktop
Expand Up @@ -64,10 +64,10 @@ export function noSSR<P = {}>(
<Loading error={null} isLoading pastDelay={false} timedOut={false} />
)

return () => (
return (props: any) => (
<Suspense fallback={fallback}>
<NoSSR>
<NoSSRComponent />
<NoSSRComponent {...props} />
</NoSSR>
</Suspense>
)
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app/app/dashboard/dynamic/dynamic-imports/dynamic-client.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ export function NextDynamicClientComponent() {
return (
<>
<Dynamic />
<DynamicNoSSR />
<DynamicNoSSR name=":suffix" />
</>
)
}
4 changes: 2 additions & 2 deletions test/e2e/app-dir/app/app/dashboard/dynamic/text-dynamic-no-ssr-client.js
View file
Open in desktop
Expand Up @@ -3,8 +3,8 @@
import { useState } from 'react'
import styles from './dynamic.module.css'

export default function Dynamic() {
let [state] = useState('dynamic no ssr on client')
export default function Dynamic({ name }) {
let [state] = useState('dynamic no ssr on client' + name)
return (
<p id="css-text-dynamic-no-ssr-client" className={styles.dynamic}>
{`next-dynamic ${state}`}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/index.test.ts
View file
Open in desktop
Expand Up @@ -171,7 +171,7 @@ describe('app dir', () => {

expect(
await browser.elementByCss('#css-text-dynamic-no-ssr-client').text()
).toBe('next-dynamic dynamic no ssr on client')
).toBe('next-dynamic dynamic no ssr on client:suffix')
})

it('should serve polyfills for browsers that do not support modules', async () => {
Expand Down