Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notifications emitted during pnpm dev #43801

Merged
merged 8 commits into from Dec 7, 2022
Merged

Remove notifications emitted during pnpm dev #43801

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1309eb0
disablen notifications in pnpm dev
jankaifer Dec 7, 2022
3f2b566
remove notify function
jankaifer Dec 7, 2022
f4dcbc6
removed node-notifier dependency
jankaifer Dec 7, 2022
cc521f9
Update pnpm-lock.yaml
timneutkens Dec 7, 2022
4b4201d
Update pnpm-lock.yaml
timneutkens Dec 7, 2022
b65b230
Fix lock
timneutkens Dec 7, 2022
8506057
Merge branch 'canary' into remove-dev-notifications
kodiakhq[bot] Dec 7, 2022
36bd2a1
Merge branch 'canary' into remove-dev-notifications
jankaifer Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 1 addition & 9 deletions packages/next/taskfile.js
View file
Open in desktop
Expand Up @@ -2418,13 +2418,5 @@ export async function release(task) {

// notification helper
function notify(msg) {
jankaifer marked this conversation as resolved.
Show resolved Hide resolved
try {
notifier.notify({
title: '▲ Next',
message: msg,
icon: false,
})
} catch (err) {
// notifier can fail on M1 machines
}
// We don't know how to easily emit notifications in M1 mac and using `notify-send` with Gnome fills notification centre.
}