Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase stack trace limit on the server #43800

Merged
merged 11 commits into from Dec 12, 2022
Merged

Increase stack trace limit on the server #43800

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8c15163
Increase stack trace limit on the server
Dec 7, 2022
5a6c2e0
Merge branch 'canary' into increase-server-stack-trace-limit
hanneslund Dec 7, 2022
b6ec846
Wrap try with if
Dec 7, 2022
ac2ccd4
Merge branch 'canary' into increase-server-stack-trace-limit
hanneslund Dec 7, 2022
a5dbe39
Add tests for call stack count
Dec 7, 2022
74345ae
Merge branch 'canary' into increase-server-stack-trace-limit
hanneslund Dec 7, 2022
266068d
Merge branch 'canary' into increase-server-stack-trace-limit
hanneslund Dec 8, 2022
5614d6c
Merge branch 'canary' of https://github.com/hanneslund/next.js into i…
Dec 9, 2022
4843df9
Merge branch 'canary' into increase-server-stack-trace-limit
ijjk Dec 12, 2022
75d6b48
Merge branch 'canary' into increase-server-stack-trace-limit
kodiakhq[bot] Dec 12, 2022
b6c4d8e
Merge branch 'canary' into increase-server-stack-trace-limit
ijjk Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/next/client/components/react-dev-overlay/internal/helpers/use-error-handler.ts
View file
Open in desktop
Expand Up @@ -22,9 +22,12 @@ function isHydrationError(error: Error): boolean {
)
}

try {
Error.stackTraceLimit = 50
} catch {}
if (typeof window !== 'undefined') {
try {
// Increase the number of stack frames on the client
Error.stackTraceLimit = 50
} catch {}
}

const errorQueue: Array<Error> = []
const rejectionQueue: Array<Error> = []
Expand Down
4 changes: 4 additions & 0 deletions packages/next/server/dev/next-dev-server.ts
View file
Open in desktop
Expand Up @@ -148,6 +148,10 @@ export default class DevServer extends Server {
}

constructor(options: Options) {
try {
// Increase the number of stack frames on the server
Error.stackTraceLimit = 50
} catch {}
super({ ...options, dev: true })
this.renderOpts.dev = true
;(this.renderOpts as any).ErrorDebug = ReactDevOverlay
Expand Down