Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding head element checking for root layout #43597

Merged
merged 4 commits into from Dec 2, 2022
+16 −8
Merged

Adding head element checking for root layout #43597

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4624b59
Add a dev warning about missing `<head/>` when using `useServerInsert…
Andarist Dec 1, 2022
b62ea9e
rm warning
huozhi Dec 2, 2022
ce79946
Revert "Root layout head not required (#41621)"
huozhi Dec 2, 2022
1d826da
Merge branch 'canary' into dx/missing-head
huozhi Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/next/server/node-web-streams-helper.ts
View file
Open in desktop
Expand Up @@ -181,6 +181,11 @@ function createHeadInsertionTransformStream(
freezing = true
inserted = true
}
if (process.env.NODE_ENV !== 'production' && insertion && !inserted) {
console.error(
`server inserted HTML couldn't be inserted into the stream. You are missing '<head/>' element in your layout - please add it.`
)
}
huozhi marked this conversation as resolved.
Show resolved Hide resolved
}

if (!inserted) {
Expand Down