Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): Update active-class-name example #43581

Merged
merged 2 commits into from Dec 1, 2022
Merged

chore(examples): Update active-class-name example #43581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ee2210
Update `active-class-name` example
joshuaslate Nov 30, 2022
bbe5cf7
Merge branch 'canary' into update-active-link-example
balazsorban44 Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 12 additions & 17 deletions examples/active-class-name/components/ActiveLink.tsx
View file
Open in desktop
@@ -1,22 +1,20 @@
import { useRouter } from 'next/router'
import Link, { LinkProps } from 'next/link'
import React, { useState, useEffect, ReactElement, Children } from 'react'
import React, { PropsWithChildren, useState, useEffect } from 'react'

type ActiveLinkProps = LinkProps & {
children: ReactElement
className?: string
activeClassName: string
}

const ActiveLink = ({
children,
activeClassName,
className,
...props
}: ActiveLinkProps) => {
}: PropsWithChildren<ActiveLinkProps>) => {
const { asPath, isReady } = useRouter()

const child = Children.only(children)
const childClassName = child.props.className || ''
const [className, setClassName] = useState(childClassName)
const [computedClassName, setComputedClassName] = useState(className)

useEffect(() => {
// Check if the router fields are updated client-side
Expand All @@ -33,29 +31,26 @@ const ActiveLink = ({

const newClassName =
linkPathname === activePathname
? `${childClassName} ${activeClassName}`.trim()
: childClassName
? `${className} ${activeClassName}`.trim()
: className

if (newClassName !== className) {
setClassName(newClassName)
if (newClassName !== computedClassName) {
setComputedClassName(newClassName)
}
}
}, [
asPath,
isReady,
props.as,
props.href,
childClassName,
activeClassName,
setClassName,
className,
computedClassName,
])

return (
<Link {...props} legacyBehavior>
{React.cloneElement(child, {
className: className || null,
})}
<Link className={computedClassName} {...props}>
{children}
</Link>
)
}
Expand Down
21 changes: 13 additions & 8 deletions examples/active-class-name/components/Nav.tsx
View file
Open in desktop
Expand Up @@ -13,23 +13,28 @@ const Nav = () => (
`}</style>
<ul className="nav">
<li>
<ActiveLink activeClassName="active" href="/">
<a className="nav-link">Home</a>
<ActiveLink activeClassName="active" className="nav-link" href="/">
Home
</ActiveLink>
</li>
<li>
<ActiveLink activeClassName="active" href="/about">
<a className="nav-link">About</a>
<ActiveLink activeClassName="active" className="nav-link" href="/about">
About
</ActiveLink>
</li>
<li>
<ActiveLink activeClassName="active" href="/blog">
<a className="nav-link">Blog</a>
<ActiveLink activeClassName="active" className="nav-link" href="/blog">
Blog
</ActiveLink>
</li>
<li>
<ActiveLink activeClassName="active" href="/[slug]" as="/dynamic-route">
<a className="nav-link">Dynamic Route</a>
<ActiveLink
activeClassName="active"
className="nav-link"
href="/[slug]"
as="/dynamic-route"
>
Dynamic Route
</ActiveLink>
</li>
</ul>
Expand Down