Allow src/app dir for ts plugin #43230
Closed
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findDir will fall back to src/app if /app not found
andparsons
requested review from
timneutkens,
ijjk,
shuding and
huozhi
as code owners
|
fixed in #43412 |
ijjk
reviewed
Dec 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next-typescript plugin currently validates files in the root /app folder.
This small change makes use of the findDir function, which will fall back to /src/app if /app not found, allowing for validtion on both the root /app folder and the fallback /src/app folder.
Bug
fixes #numbercontributing.md