Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary async function when preloading async components #42957

Merged
merged 4 commits into from Nov 18, 2022
Merged

Remove unnecessary async function when preloading async components #42957

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff778db
Catch promise rejection but ignore return value
Nov 15, 2022
1e842d4
Merge branch 'canary' into preload-async-component
Nov 15, 2022
44227ff
Merge branch 'canary' into preload-async-component
Nov 16, 2022
605f2ce
Merge branch 'canary' into preload-async-component
Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 6 additions & 17 deletions packages/next/server/app-render.tsx
View file
Open in desktop
Expand Up @@ -59,23 +59,12 @@ function preloadComponent(Component: any, props: any) {
}
try {
let result = Component(props)
if (result && result.then) {
result = result
.then((res: any) => {
return { success: res }
})
.catch((err: Error) => {
return { error: err }
})
return async () => {
const res = await result
if (res.error) {
throw res.error
}
if (res.success) {
return res.success
}
}
if (result && typeof result.then === 'function') {
// Catch promise rejections to prevent unhandledRejection errors
result.then(
() => {},
() => {}
)
}
return function () {
// We know what this component will render already.
Expand Down