Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolving for esm package with only exports.import condition #42767

Merged
merged 2 commits into from Nov 11, 2022
Merged

Fix resolving for esm package with only exports.import condition #42767

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0338fb0
Fix resolving for esm package with only exports.import condition
huozhi Nov 11, 2022
7e3ee6d
update tests
huozhi Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/build/webpack-config.ts
View file
Open in desktop
Expand Up @@ -1641,7 +1641,7 @@ export default async function getBaseWebpackConfig(
return true
},
resolve: {
conditionNames: ['react-server', 'node', 'require'],
conditionNames: ['react-server', 'node', 'import', 'require'],
alias: {
// If missing the alias override here, the default alias will be used which aliases
// react to the direct file path, not the package name. In that case the condition
Expand Down
4 changes: 3 additions & 1 deletion test/e2e/app-dir/app-external/node_modules_bak/random-module-instance/package.json
View file
Open in desktop
@@ -1,5 +1,7 @@
{
"name": "random-module-instance",
"type": "module",
"exports": "./index.js"
"exports": {
"import": "./index.js"
}
}