New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next/swc): allow to run custom turbopack binary #42656
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
98afec8
refactor(next/dev): simplify turbopack bootstrap
kwonoj 5c936a1
feat(next/swc): support isCustomTurbopack
kwonoj 799ba11
refactor(next/dev): support custom turbopack
kwonoj 9cd4c8f
fix(next/dev): correct args
kwonoj 78c4d81
feat(next/swc): run custom turbopack binary
kwonoj 7b0bde2
Apply suggestions from code review
ijjk 15ff8d3
Merge branch 'canary' into turbopack-custom-bin
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to be a custom
swc/index.js
that wraps loading the bindings again or the napi build itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected usecase is
__INTERNAL_CUSTOM_TURBOPACK_BINDINGS
points to the native napi bindings directly (.node
), reason this does not passesBuffer
for the options. It is up to caller's responsibility to prepare bindings to work with suggested interface, either if it's custom wrapped .js or direct call to.node
binary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly did not throughly consider possible edge cases for this path, as turbopack itself currently dose not produce napi bindings binaries yet. Potentially there'll be a couple of iteration based on turbopack side changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah can be updated in follow-ups as needed from testing