Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entry creation on Windows #42421

Merged
merged 2 commits into from Nov 3, 2022
Merged

Fix entry creation on Windows #42421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e35fec
fix typo
shuding Nov 3, 2022
5e104b5
fix absolute path check
shuding Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/build/webpack/plugins/flight-client-entry-plugin.ts
View file
Open in desktop
Expand Up @@ -189,7 +189,7 @@ export class FlightClientEntryPlugin {
dependency: layoutOrPageDependency,
})

const isAbsoluteRequest = layoutOrPageRequest[0] === '/'
const isAbsoluteRequest = path.isAbsolute(layoutOrPageRequest)

// Next.js internals are put into a separate entry.
if (!isAbsoluteRequest) {
Expand Down
2 changes: 1 addition & 1 deletion packages/next/build/webpack/plugins/flight-manifest-plugin.ts
View file
Open in desktop
Expand Up @@ -201,7 +201,7 @@ export class FlightManifestPlugin {
},
}
} else {
// It is possible that there are mtuliepl modules with the same resouce,
// It is possible that there are multiple modules with the same resource,
// e.g. extracted by mini-css-extract-plugin. In that case we need to
// merge the chunks.
manifest[resource].default.chunks = [
Expand Down