Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix as option with optional catch all routes url object syntax #42355

Merged
merged 2 commits into from Nov 10, 2022
Merged

Fix as option with optional catch all routes url object syntax #42355

merged 2 commits into from Nov 10, 2022

Commits on Nov 2, 2022

  1. Fix as option with optional catch all routes 

    `as` option used to throw with url object syntax: optional attribute were not taken into account when checking missing parameters in router change method.
Fixes vercel#41624
    @cvolant
    cvolant committed Nov 2, 2022
    Copy the full SHA
    be83e50 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge branch 'canary' into fix/41624-link-as-prop-throw-with-optional… 

    …-catch-all-routes-url-object-syntax
    @ijjk
    ijjk committed Nov 10, 2022
    Copy the full SHA
    b3def72 View commit details
    Browse the repository at this point in the history