Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add never return type for redirect() and notFound() #42009

Merged
merged 2 commits into from Oct 27, 2022
Merged

Add never return type for redirect() and notFound() #42009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb8ef2
Add never return type for redirect() and notFound()
timneutkens Oct 27, 2022
bd9629b
Merge branch 'canary' into fix/add-never-to-notfound-redirect
kodiakhq[bot] Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/client/components/not-found.ts
View file
Open in desktop
@@ -1,6 +1,6 @@
export const NOT_FOUND_ERROR_CODE = 'NEXT_NOT_FOUND'

export function notFound() {
export function notFound(): never {
// eslint-disable-next-line no-throw-literal
const error = new Error(NOT_FOUND_ERROR_CODE)
;(error as any).digest = NOT_FOUND_ERROR_CODE
Expand Down
2 changes: 1 addition & 1 deletion packages/next/client/components/redirect.ts
View file
Open in desktop
@@ -1,6 +1,6 @@
export const REDIRECT_ERROR_CODE = 'NEXT_REDIRECT'

export function redirect(url: string) {
export function redirect(url: string): never {
// eslint-disable-next-line no-throw-literal
const error = new Error(REDIRECT_ERROR_CODE)
;(error as any).digest = REDIRECT_ERROR_CODE + ';' + url
Expand Down