Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge entry layer resolution bug #41757

Merged
merged 2 commits into from Oct 25, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 16 additions & 10 deletions packages/next/build/webpack-config.ts
Expand Up @@ -729,6 +729,16 @@ export default async function getBaseWebpackConfig(
babel: getBabelOrSwcLoader(),
}

const swcLoaderForRSC = hasServerComponents
? useSWCLoader
? getSwcLoader({ isServerLayer: true })
: // When using Babel, we will have to add the SWC loader
// as an additional pass to handle RSC correctly.
// This will cause some performance overhead but
// acceptable as Babel will not be recommended.
[getSwcLoader({ isServerLayer: true }), getBabelLoader()]
: []

const pageExtensions = config.pageExtensions

const outputPath =
Expand Down Expand Up @@ -1789,16 +1799,12 @@ export default async function getBaseWebpackConfig(
test: codeCondition.test,
issuerLayer: WEBPACK_LAYERS.server,
exclude: [staticGenerationAsyncStorageRegex],
use: useSWCLoader
? getSwcLoader({ isServerLayer: true })
: // When using Babel, we will have to add the SWC loader
// as an additional pass to handle RSC correctly.
// This will cause some performance overhead but
// acceptable as Babel will not be recommended.
[
getSwcLoader({ isServerLayer: true }),
getBabelLoader(),
],
use: swcLoaderForRSC,
},
{
test: codeCondition.test,
resourceQuery: /__edge_ssr_entry__/,
use: swcLoaderForRSC,
},
]
: []),
Expand Down
8 changes: 8 additions & 0 deletions test/e2e/app-dir/app/app/edge-apis/cookies/page.js
@@ -0,0 +1,8 @@
import { cookies } from 'next/headers'

export const runtime = 'experimental-edge'

export default function Page() {
cookies()
return <h1>Hello!</h1>
}
5 changes: 5 additions & 0 deletions test/e2e/app-dir/index.test.ts
Expand Up @@ -955,6 +955,11 @@ describe('app dir', () => {
}
})

it('should retrieve cookies in a server component in the edge runtime', async () => {
const res = await fetchViaHTTP(next.url, '/edge-apis/cookies')
expect(await res.text()).toInclude('Hello')
})

it('should access cookies on <Link /> navigation', async () => {
const browser = await webdriver(next.url, '/navigation')

Expand Down