Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach module trace for RSC related errors #40652

Merged
merged 1 commit into from Sep 18, 2022
Merged

Attach module trace for RSC related errors #40652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/next/client/dev/error-overlay/format-webpack-messages.js
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@ function formatMessage(message, verbose) {
message.moduleTrace &&
message.moduleTrace.filter(
(trace) =>
!/next-(middleware|client-pages|edge-function|flight-(client|server))-loader\.js/.test(
!/next-(middleware|client-pages|edge-function)-loader\.js/.test(
trace.originName
)
)
Expand All @@ -62,7 +62,7 @@ function formatMessage(message, verbose) {
(message.details && verbose ? '\n' + message.details : '') +
(filteredModuleTrace && filteredModuleTrace.length && verbose
? '\n\nImport trace for requested module:' +
filteredModuleTrace.map((trace) => `\n${trace.originName}`).join('')
filteredModuleTrace.map((trace) => `\n${trace.moduleName}`).join('')
: '') +
(message.stack && verbose ? '\n' + message.stack : '')
}
Expand Down Expand Up @@ -171,6 +171,17 @@ function formatMessage(message, verbose) {

function formatWebpackMessages(json, verbose) {
const formattedErrors = json.errors.map(function (message) {
// TODO: Shall we use invisible characters in the original error
// message as meta information?
if (
message &&
message.message &&
/ (Client|Server) Components compilation\./.test(message.message)
) {
// Comes from the "React Server Components" transform in SWC, always
// attach the module trace.
verbose = true
}
return formatMessage(message, verbose)
})
const formattedWarnings = json.warnings.map(function (message) {
Expand Down