Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure smooth scroll is disabled for navigation in new and existing router #40642

Merged
merged 4 commits into from Sep 19, 2022
Merged

Ensure smooth scroll is disabled for navigation in new and existing router #40642

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a9963c
Ensure smooth scroll is disabled for navigation in new router
timneutkens Sep 17, 2022
129537a
Use documentElement instead
timneutkens Sep 17, 2022
792dc1d
Reset value
timneutkens Sep 17, 2022
1405f6f
Add handling of smooth scroll in existing router
timneutkens Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/next/client/components/layout-router.client.tsx
View file
Open in desktop
Expand Up @@ -164,7 +164,11 @@ export function InnerLayoutRouter({
focusAndScrollElementRef.current.focus()
// Only scroll into viewport when the layout is not visible currently.
if (!topOfElementInViewport(focusAndScrollElementRef.current)) {
const htmlElement = document.documentElement
const existing = htmlElement.style.scrollBehavior
htmlElement.style.scrollBehavior = 'auto'
focusAndScrollElementRef.current.scrollIntoView()
htmlElement.style.scrollBehavior = existing
}
}
}, [focusAndScrollRef])
Expand Down