Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mention linking react and react-dom locally #40514

Closed
wants to merge 1 commit into from

Conversation

balazsorban44
Copy link
Member

Closes #40499

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@@ -136,18 +136,32 @@ EXAMPLE=./test/integration/basic

There are two options to develop with your local version of the codebase:

### Develop inside the monorepo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this gives a better DX, I suggest we switch the order here.

@balazsorban44
Copy link
Member Author

Closing in favor of #40515

@balazsorban44 balazsorban44 deleted the docs/issue-40499 branch October 1, 2022 04:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next.js built from source errors when linked to build other projects
1 participant