Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#40388): next/dynamic should only add default loading without suspense #40397

Merged
merged 8 commits into from Sep 9, 2022
Merged

fix(#40388): next/dynamic should only add default loading without suspense #40397

merged 8 commits into from Sep 9, 2022

Commits on Sep 9, 2022

  1. fix(vercel#40388): only add default loading for non-suspense

    @SukkaW
    SukkaW committed Sep 9, 2022
    Copy the full SHA
    75c9a2c View commit details
    Browse the repository at this point in the history

  2. test(vercel#40388): validate the fix

    @SukkaW
    SukkaW committed Sep 9, 2022
    Copy the full SHA
    7cf54dc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'canary' into fix-40388

    @SukkaW
    SukkaW committed Sep 9, 2022
    Copy the full SHA
    bc6fdcf View commit details
    Browse the repository at this point in the history

  4. apply code review suggestions by @huozhi 

    Co-authored-by: huozhi <inbox@huozhi.im>
    @SukkaW @huozhi
    SukkaW and huozhi committed Sep 9, 2022
    Copy the full SHA
    69f8a9c View commit details
    Browse the repository at this point in the history

  5. apply code review suggestions by @huozhi 

    Co-authored-by: Jiachi Liu <inbox@huozhi.im>
    @SukkaW @huozhi
    SukkaW and huozhi committed Sep 9, 2022
    Copy the full SHA
    0df8255 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'canary' into fix-40388

    @ijjk
    ijjk committed Sep 9, 2022
    Copy the full SHA
    7a9ebcb View commit details
    Browse the repository at this point in the history

  7. Merge branch 'canary' into fix-40388

    @kodiakhq
    kodiakhq[bot] committed Sep 9, 2022
    Copy the full SHA
    0f560a2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'canary' into fix-40388

    @kodiakhq
    kodiakhq[bot] committed Sep 9, 2022
    Copy the full SHA
    ac450b2 View commit details
    Browse the repository at this point in the history