Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop build warning about experimental: { esmExternals: 'loose' } #40377

Merged
merged 3 commits into from Sep 9, 2022
Merged

Stop build warning about experimental: { esmExternals: 'loose' } #40377

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7b2605
fixed config-schema for esmExternals
rubytree33 Sep 9, 2022
39cf9bf
formatting
rubytree33 Sep 9, 2022
7faed2b
esmExternals config schema minor idiomatic edit
rubytree33 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/next/server/config-schema.ts
View file
Open in desktop
Expand Up @@ -253,7 +253,14 @@ const configSchema = {
type: 'boolean',
},
esmExternals: {
type: 'boolean',
oneOf: [
{
type: 'boolean',
},
{
const: 'loose',
},
] as any,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw as any elsewhere in this file wherever oneOf?: is used in the schema, which should probably be fixed for type safety, but I'm not sure why it breaks without that.

},
externalDir: {
type: 'boolean',
Expand Down