Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show asPath on large page data warning #39071

Merged
merged 4 commits into from Jul 27, 2022
Merged

fix: show asPath on large page data warning #39071

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf7d360
fix: show `asPath` on large page data warning
balazsorban44 Jul 27, 2022
5c0b6d3
Add test case for updated message
ijjk Jul 27, 2022
89d1c2c
Merge branch 'canary' into fix/issue-39057
ijjk Jul 27, 2022
dde05b6
Merge branch 'canary' into fix/issue-39057
ijjk Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/next/pages/_document.tsx
View file
Open in desktop
Expand Up @@ -978,7 +978,11 @@ export class NextScript extends Component<OriginProps> {

if (largePageDataBytes && bytes > largePageDataBytes) {
console.warn(
`Warning: data for page "${__NEXT_DATA__.page}" is ${prettyBytes(
`Warning: data for page "${__NEXT_DATA__.page}"${
__NEXT_DATA__.page === context.dangerousAsPath
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason this is called dangerousAsPath?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we named it this to stress it wasn't normalized/sanitized although it was mainly added for rendering the canonical meta tag for AMP.

? ''
: ` (path "${context.dangerousAsPath}")`
} is ${prettyBytes(
bytes
)} which exceeds the threshold of ${prettyBytes(
largePageDataBytes
Expand Down