Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments in new router reducer #39025

Merged
merged 35 commits into from Jul 27, 2022
Merged

Add comments in new router reducer #39025

merged 35 commits into from Jul 27, 2022

Commits on Jul 25, 2022

  1. Convert const to function

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    0bbbae1 View commit details
    Browse the repository at this point in the history

  2. Remove already handled todo

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    57c7626 View commit details
    Browse the repository at this point in the history

  3. Refactor reducer to switch, remove payload, change type to variable

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    79b4365 View commit details
    Browse the repository at this point in the history

  4. Infer useReducer type automatically

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    3d7c9ab View commit details
    Browse the repository at this point in the history

  5. Remove obsolete providers from app-render

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    e3ffe55 View commit details
    Browse the repository at this point in the history

  6. Add comments for AppRouterInstance

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    8fc3733 View commit details
    Browse the repository at this point in the history

  7. Add comments to app-router

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    00fcfac View commit details
    Browse the repository at this point in the history

  8. Additional comments

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    3daed15 View commit details
    Browse the repository at this point in the history

  9. Add todo

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    6406e4b View commit details
    Browse the repository at this point in the history

  10. Remove additional type

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    b4cc000 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'canary' of github.com:vercel/next.js into add/refactor-… 

    …router
    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    5974831 View commit details
    Browse the repository at this point in the history

  12. Add comment to hooks-client

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    93c2121 View commit details
    Browse the repository at this point in the history

  13. Simplify rendering a bit

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    9f099e7 View commit details
    Browse the repository at this point in the history

  14. Add comments / refactor names

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    72225ef View commit details
    Browse the repository at this point in the history

  15. Refactor dynamic segment handling

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    9639c23 View commit details
    Browse the repository at this point in the history

  16. Add comments

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    58d8750 View commit details
    Browse the repository at this point in the history

  17. Add additional comments

    @timneutkens
    timneutkens committed Jul 25, 2022
    Copy the full SHA
    0db5c9e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Remove segment from childProp

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    4f54b93 View commit details
    Browse the repository at this point in the history

  2. Update layout-router.client.tsx

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    f930b0a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'canary' into add/refactor-router

    @kodiakhq
    kodiakhq[bot] committed Jul 26, 2022
    Copy the full SHA
    36cb5db View commit details
    Browse the repository at this point in the history

  4. Add additional comments to layout-router

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    0eea4e6 View commit details
    Browse the repository at this point in the history

  5. Add additional comments

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    f814439 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'canary' of github.com:vercel/next.js into add/refactor-… 

    …router
    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    e833caa View commit details
    Browse the repository at this point in the history

  7. Add explanation of individual actions

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    596992d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'add/refactor-router' of github.com:timneutkens/next.js … 

    …into add/refactor-router
    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    2d6a281 View commit details
    Browse the repository at this point in the history

  9. Add comments to navigate

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    157e89d View commit details
    Browse the repository at this point in the history

  10. Add further comments for reducer

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    8397195 View commit details
    Browse the repository at this point in the history

  11. Revert childProp.segment removal

    @timneutkens
    timneutkens committed Jul 26, 2022
    Copy the full SHA
    568e857 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Update packages/next/client/components/app-router.client.tsx 

    Co-authored-by: Wyatt Johnson <accounts+github@wyattjoh.ca>
    @timneutkens @wyattjoh
    timneutkens and wyattjoh committed Jul 27, 2022
    Copy the full SHA
    3797baf View commit details
    Browse the repository at this point in the history

  2. Add readonly 

    Co-Authored-By: Wyatt Johnson <accounts+github@wyattjoh.ca>
    @timneutkens @wyattjoh
    timneutkens and wyattjoh committed Jul 27, 2022
    Copy the full SHA
    4eae282 View commit details
    Browse the repository at this point in the history

  3. Update packages/next/client/components/reducer.ts 

    Co-authored-by: Wyatt Johnson <accounts+github@wyattjoh.ca>
    @timneutkens @wyattjoh
    timneutkens and wyattjoh committed Jul 27, 2022
    Copy the full SHA
    270c8ec View commit details
    Browse the repository at this point in the history

  4. Update packages/next/client/components/reducer.ts 

    Co-authored-by: Yuddomack <41747333+Yuddomack@users.noreply.github.com>
    @timneutkens @Yuddomack
    timneutkens and Yuddomack committed Jul 27, 2022
    Copy the full SHA
    293b227 View commit details
    Browse the repository at this point in the history

  5. Throw error instead

    @timneutkens
    timneutkens committed Jul 27, 2022
    Copy the full SHA
    aab0242 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'add/refactor-router' of github.com:timneutkens/next.js … 

    …into add/refactor-router
    @timneutkens
    timneutkens committed Jul 27, 2022
    Copy the full SHA
    8a7e4d6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'canary' into add/refactor-router

    @kodiakhq
    kodiakhq[bot] committed Jul 27, 2022
    Copy the full SHA
    c742b00 View commit details
    Browse the repository at this point in the history