New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#38743): config.runtime support template literal #38750
Merged
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5bc2585
fix(#38743): config.runtime support template literal
SukkaW f35478e
test: fix fixture
SukkaW dcbfbde
feat: show a warning about unrecognized `export config`
SukkaW 754c515
Merge branch 'canary' into fix-38743
SukkaW 83f753f
refactor: simplify the logic
SukkaW 6dc3e28
fix: make sure unrecognized value is only warned once
SukkaW f55f103
test: add "warns on unrecognized runtimes value"
SukkaW d7a713c
docs(errors): update invalid page config
SukkaW e34ba69
refactor: remove `tryToExtractExportedConstValue`
SukkaW 1858c1a
docs(errors): improve invalid-page-config readability
SukkaW 3615bd9
Merge branch 'canary' into fix-38743
ijjk edd4b40
Merge branch 'canary' into fix-38743
kodiakhq[bot] adfe7b1
Merge branch 'canary' into fix-38743
ijjk File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default (req) => { | ||
return new Response(`Returned by Edge API Route ${req.url}`) | ||
} | ||
|
||
export const config = { | ||
runtime: `experimental-edge`, | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: It is fair to not support real interpolation.
The best option would be to load the file and check the exported value. However, that's not an option, so we can go with this tradeoff.