Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates in dependencies versions :) #38328

Closed
wants to merge 8 commits into from
Closed

Minor updates in dependencies versions :) #38328

wants to merge 8 commits into from

Conversation

sanjaiyan-dev
Copy link
Contributor

@sanjaiyan-dev sanjaiyan-dev commented Jul 5, 2022

Upgrading to latest version core-js module. For more info-: https://github.com/zloirock/core-js/releases

Adding fetchpritory atrribute for more info-: https://web.dev/priority-hints/

@sanjaiyan-dev
Copy link
Contributor Author

Extremely sorry if I made any mistakes 💪🙌

Copy link
Contributor Author

@sanjaiyan-dev sanjaiyan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed fetchpritory prop from Image components :)

Copy link
Contributor Author

@sanjaiyan-dev sanjaiyan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely sorry, Now only I noticed that we need to change /features/ to /full/

https://github.com/zloirock/core-js/releases/tag/v3.22.0

Copy link
Contributor Author

@sanjaiyan-dev sanjaiyan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating whatwg-fetch lib

@sanjaiyan-dev sanjaiyan-dev changed the title Upgrading core js pollyfill module version and adding new fetchpriority atrribute to the image tags. Upgrading core-js & whatwg-fetch pollyfill module version. Jul 6, 2022
Copy link
Contributor Author

@sanjaiyan-dev sanjaiyan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

Sorry if I made any mistakes :(

@sanjaiyan-dev sanjaiyan-dev changed the title Upgrading core-js & whatwg-fetch pollyfill module version. Minor update in dependencies :) Jul 6, 2022
@sanjaiyan-dev sanjaiyan-dev changed the title Minor update in dependencies :) Minor updates in dependencies versions :) Jul 6, 2022
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile needs to be updated

Please run pnpm install from the root directory

https://github.com/vercel/next.js/blob/canary/contributing.md

Then you need to compile ncc again with cd packages/next && pnpm run ncc-compiled

@sanjaiyan-dev
Copy link
Contributor Author

Sorry I will create new PR :)

@sanjaiyan-dev
Copy link
Contributor Author

sanjaiyan-dev commented Jul 9, 2022

The lockfile needs to be updated

Please run pnpm install from the root directory

https://github.com/vercel/next.js/blob/canary/contributing.md

Then you need to compile ncc again with cd packages/next && pnpm run ncc-compiled

Sir, I made new and updated PR.

#38427

kodiakhq bot pushed a commit that referenced this pull request Jul 11, 2022
Hi,

I have updated some version of packages. 

- @swc/helper
- json5
- terser
- postcss
- nanoid
- use-sync-external-store (ReactJs pollyfill)
- microbundle

Updated version of #38328 

_Extremely sorry if I made any mistakes :(_

Co-authored-by: Jiachi Liu <4800338+huozhi@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants