-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when next/future/image
is missing width or height
#38132
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
45e1664
Fix error when `next/future/image` is missing width or height
styfle e63e1c4
Fix TS error
styfle ed67617
Fix missing width/height on another test
styfle 707f16c
Fix another test missing width/height
styfle 350ce5d
Merge branch 'canary' into next-future-image-missing-width-height
styfle aad5781
Revert accidental test comment
styfle 75cb4e7
Merge branch 'canary' into next-future-image-missing-width-height
kodiakhq[bot] 578cc6f
Merge branch 'canary' into next-future-image-missing-width-height
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
test/integration/image-future/default/pages/invalid-height.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import React from 'react' | ||
import Image from 'next/future/image' | ||
|
||
export default function Page() { | ||
return ( | ||
<div> | ||
<p>Invalid height</p> | ||
|
||
<Image src="/test.jpg" width={400} height="50vh" /> | ||
</div> | ||
) | ||
} |
18 changes: 0 additions & 18 deletions
18
test/integration/image-future/default/pages/invalid-width-or-height.js
This file was deleted.
Oops, something went wrong.
12 changes: 12 additions & 0 deletions
12
test/integration/image-future/default/pages/invalid-width.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import React from 'react' | ||
import Image from 'next/future/image' | ||
|
||
export default function Page() { | ||
return ( | ||
<div> | ||
<p>Invalid width</p> | ||
|
||
<Image src="/test.jpg" width="100%" height={300} /> | ||
</div> | ||
) | ||
} |
11 changes: 11 additions & 0 deletions
11
test/integration/image-future/default/pages/missing-height.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import React from 'react' | ||
import Image from 'next/future/image' | ||
|
||
export default function Page() { | ||
return ( | ||
<div> | ||
<h1>Missing height</h1> | ||
<Image src="/test.jpg" width="100" /> | ||
</div> | ||
) | ||
} |
11 changes: 11 additions & 0 deletions
11
test/integration/image-future/default/pages/missing-width.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import React from 'react' | ||
import Image from 'next/future/image' | ||
|
||
export default function Page() { | ||
return ( | ||
<div> | ||
<h1>Missing width or height</h1> | ||
<Image src="/test.jpg" height={100} /> | ||
</div> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, fixed!
(must have been changed by running tests locally)