Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/with-playwritght): use PORT env variable and fall back to 3000 #38107

Merged
merged 7 commits into from
Jul 8, 2022
Merged

fix(examples/with-playwritght): use PORT env variable and fall back to 3000 #38107

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5669aa2
fix(examples/with-playwritght): use PORT env variable and fall back t…
Jun 28, 2022
44664e4
chore(examples): make use of copy in github and split bash commands
Jun 29, 2022
040dc79
fix(examples): set baseURL and url for webserver respecting PORT env …
Jun 29, 2022
72278f6
Merge branch 'canary' into fix/playwright-example-port
thebergamo Jun 29, 2022
7914c00
Merge branch 'canary' into fix/playwright-example-port
thebergamo Jul 7, 2022
b4e49ca
chore: revert README.md
Jul 7, 2022
87e0a99
Merge branch 'canary' into fix/playwright-example-port
kodiakhq[bot] Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion examples/with-playwright/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import { PlaywrightTestConfig, devices } from '@playwright/test'
import path from 'path'

// Use process.env.PORT by default and fallback to port 3000
const PORT = process.env.PORT || 3000

// Set webServer.url and use.baseURL with the location of the WebServer respecting the correct set port
const baseURL = `http://localhost:${PORT}`

// Reference: https://playwright.dev/docs/test-configuration
const config: PlaywrightTestConfig = {
// Timeout per test
Expand All @@ -16,12 +22,16 @@ const config: PlaywrightTestConfig = {
// https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests
webServer: {
command: 'npm run dev',
port: 3000,
url: baseURL,
timeout: 120 * 1000,
reuseExistingServer: !process.env.CI,
},

use: {
// Use baseURL so to make navigations relative.
// More information: https://playwright.dev/docs/api/class-testoptions#test-options-base-url
baseURL,

// Retry a test if its failing with enabled tracing. This allows you to analyse the DOM, console logs, network traffic etc.
// More information: https://playwright.dev/docs/trace-viewer
trace: 'retry-with-trace',
Expand Down